-
Notifications
You must be signed in to change notification settings - Fork 191
George Alexander Saavedra #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
George-Alexander-S
wants to merge
19
commits into
boolean-uk:main
Choose a base branch
from
George-Alexander-S:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er1 which is logged inn, as well as clickable profile names on each of the posters
…rerendering errors. However, fixed the initials displayed as required
…le.jsx - Added a check for cases where the user hasnt loaded yet. Commenter.jx - Added postId to the useEffect dependency array, so as to consistently load comments to a post. Previous version required going in and out of the post
…ser, Header, Sidebar - Made own element for logged in user, and its own UserProvider function, ThisPost - Corrected the dependency array in the useEffect, it no longer sends continous requests and corrected how I pass the PostId, now passing directly from the UseParams. Thus posting from the single post view now correctly works. Other changes: Added toReversed() in the correct place in Commenter.jsx - Thus posts are rendered in reverse chronoligical order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.